TinyMCE: potential fix for code scanning alert: Inefficient regular expression #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…pression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
sreichel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/OpenMage/magento-lts/security/code-scanning/102
To fix the problem, we need to modify the regular expression to remove the ambiguity that causes exponential backtracking. We can achieve this by ensuring that the sub-expression inside the repetition does not have multiple ways to match the same string. Specifically, we can replace
(?:\\.|[^'])with a more precise pattern that avoids ambiguity.In this case, we can use a negative lookahead to ensure that we match any character except a single quote or a backslash followed by any character. This approach eliminates the ambiguity and prevents exponential backtracking.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.