Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SonarQube action #4489

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Updated SonarQube action #4489

wants to merge 12 commits into from

Conversation

sreichel
Copy link
Contributor

This action is deprecated and will be removed in a future release. Please use the sonarqube-scan-action action instead. The sonarqube-scan-action is a drop-in replacement for this action.

@colinmollenhour there is another waring ...

Warning: Running this GitHub Action without SONAR_TOKEN is not recommended

Can you please add one? Maybe it resolves missing coverage reports.

@colinmollenhour
Copy link
Member

There was already a SONAR_TOKEN created 3 years ago, but I just updated it with a token created with my account that has the OM org.

@sreichel
Copy link
Contributor Author

Tested. Its still empty. ❓

SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

@sreichel
Copy link
Contributor Author

If the secret is set, lets approve to update the action for now.

@fballiano
Copy link
Contributor

secrets are not visible in all types of workflows: pypa/gh-action-pypi-publish#49 (comment)

@sreichel sreichel marked this pull request as draft January 18, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants