Chore: Check for DS / PS already set
#4484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Reports
sreichel
force-pushed
the
define-ds-bp
branch
from
f5a7b73 to
8894fe9
Compare
|
fballiano
reviewed
Jan 15, 2025
Comment on lines
+271
to
+301
|
|
||
|
|
||
| /** | ||
| * Get SQL for get record count | ||
| * | ||
| * @return Varien_Db_Select | ||
| * @see Mage_Reports_Model_Resource_Report_Product_Viewed_Collection | ||
| * @see Mage_Sales_Model_Resource_Report_Bestsellers_Collection | ||
| */ | ||
| public function getSelectCountSql() | ||
| { | ||
| $this->_renderFilters(); | ||
| $select = clone $this->getSelect(); | ||
| $select->reset(Zend_Db_Select::ORDER); | ||
| return $this->getConnection()->select()->from($select, 'COUNT(*)'); | ||
| } | ||
|
|
||
| /** | ||
| * Set ids for store restrictions | ||
| * | ||
| * @param array $storeIds | ||
| * @return $this | ||
| * @see Mage_Reports_Model_Resource_Report_Product_Viewed_Collection | ||
| * @see Mage_Sales_Model_Resource_Report_Bestsellers_Collection | ||
| */ | ||
| public function addStoreRestrictions($storeIds) | ||
| { | ||
| if (!is_array($storeIds)) { | ||
| $storeIds = [$storeIds]; | ||
| } | ||
| $currentStoreIds = $this->_storesIds; |
There was a problem hiding this comment.
this should be in a separate PR for easier review
There was a problem hiding this comment.
For some reason i dont see that comment/review in history?
It moved 1:1 duplicated methods to its parent abtract class.
There was a problem hiding this comment.
Its one commit cb3fbba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
@justinbeaty, only to remove some changes from #4411, to make review easier.