Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorter copyright header #4467

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Shorter copyright header #4467

wants to merge 5 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 9, 2025 •
edited
Loading

Description (*)

No need to mention license again.

@sreichel sreichel added the chore label Jan 9, 2025
@Axepih
Copy link

Axepih commented Jan 11, 2025

Hi,

What do you think of what piwigo has done?
Piwigo/Piwigo@fc193f7

The copyright is available in a single file COPYING.txt
https://github.com/Piwigo/Piwigo/blob/master/COPYING.txt

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: AdminNotification Relates to Mage_AdminNotification Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Api PageRelates to Mage_Api Component: Cron Relates to Mage_Cron Component: Captcha Relates to Mage_Captcha Component: Contacts Relates to Mage_Contacts Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: CatalogRule Relates to Mage_CatalogRule Component: Admin Relates to Mage_Admin Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet labels Jan 11, 2025
@github-actions github-actions bot added Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow labels Jan 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel
Copy link
Contributor Author

I think we should keep at in files for now.

Put it into a single file should be discussed in detail.

@sreichel sreichel modified the milestones: 20.13.0, 20.14.0 Jan 17, 2025
fballiano
fballiano reviewed Jan 20, 2025
View reviewed changes
api.php
Comment on lines -13 to +7
* @copyright Copyright (c) 2021-2024 The OpenMage Contributors (https://www.openmage.org)
* @copyright Copyright (c) 2021-2025 The OpenMage Contributors (https://www.openmage.org)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines (bumping the year) should be avoided in the context of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be reasons to keep it.

(Fab, as long as i am block by you, please stay away from my PRs. Thanks.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano left review comments

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

@Hanmac Hanmac Awaiting requested review from Hanmac

@kiatng kiatng Awaiting requested review from kiatng

@addison74 addison74 Awaiting requested review from addison74

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
chore Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Mage.php Relates to app/Mage.php
Projects
None yet
Milestone
20.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @Axepih @fballiano