Replaced google dashboard charts with Chart.js (via composer) #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : admin
# Conflicts: # composer.lock
|
Draft until composer-pluig v2 is released. |
# Conflicts: # composer.lock
|
You still need to apply the Missing Data fix from this PR #3594 |
# Conflicts: # composer.json # composer.lock
|
Of course ... its just to replace the charts :) |
# Conflicts: # app/design/adminhtml/default/default/template/dashboard/graph.phtml # composer.json # composer.lock
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
https://github.com/chartjs comes with a composer file, but unfortunatly its broken since v3 and has no
distdirectory in it (containing built js and css files). Until its fixed composer plugin tries to download files from https://cdn.jsdelivr.net/npm/[email protected] (or later)Multiple datarows may come later.
Related Pull Requests
Better JS lazy load from MahoCommerce/maho@b4e66fc