The coupon is not valid and discount is not applied

[fabianaromagnoli]

It solves the issue reported here #4401.

Preconditions
OpenMage version 20.6.0
PHP 8.0

Steps to reproduce
Setup a cart promo rule with a specific coupon. Set both start date and end date with current date.
Go to fronted, add a product to cart and go to the cart page
Try to apply the coupon

Expected result
The coupon is valid and discount is applied

Actual result
The coupon is not valid and discount is not applied

In this piece of code the coupon expiration date is compared to the current datetime, but coupon expiration date always has 00:00:00 time, so that if the expiration day is today, that check cannot pass. Dates should be compared without considering time, like it's done in the Collection where the promo validity dates are compared to $now, and $now is a date without time.

[sreichel]

Id change the code to not call getExpirationDate before hasExpirationDate.

[fabianaromagnoli]

@sreichel Thanks for pointing out! What do you think about the refactoring in commit 3cff24f? The very bad thing before this commit was that $couponExpirationDay had a not-null value even when the coupon had no expiration date. Now it is explicitly null if coupon has no expiration date.

[sreichel]

Mhh, i think that the original code works as expected.

To make a coupon valid only for this this set "to date" to the next day. (thats 00:00:00) - but that unintentional.

I have tested your code, but it does enot work for me. I have an one-day offset in comparison. Wait for PR ...

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud