-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed null deprecation in UnserializeArray.php #4394
Open
kiatng
wants to merge
21
commits into
OpenMage:main
Choose a base branch
from
kiatng:4352_nd_unserialize_array
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5644286
Fixed issue #4352 null deprecation in UnserializeArray.php
kiatng e3cd1d6
Added @ to suppress warnings and notices
kiatng be23e65
Suppress PHPMD ErrorControlOperator
kiatng f73292b
Fix suppress PHPMD ErrorControlOperator
kiatng 8e41850
Merge branch 'main' into 4352_nd_unserialize_array
sreichel 18fd93c
Merge branch 'main' into 4352_nd_unserialize_array
sreichel 852bdc6
Merge branch 'main' into 4352_nd_unserialize_array
sreichel c70f0da
Merge branch 'main' into 4352_nd_unserialize_array
sreichel 349f27e
Merge branch 'main' into 4352_nd_unserialize_array
sreichel dbb3095
Merge branch 'main' into 4352_nd_unserialize_array
sreichel 3039d23
Merge branch 'main' into 4352_nd_unserialize_array
kiatng f9d40e7
Merge branch 'main' into 4352_nd_unserialize_array
sreichel adef3d2
Update app/code/core/Mage/Core/Helper/UnserializeArray.php
sreichel debdfad
Update app/code/core/Mage/Core/Helper/UnserializeArray.php
kiatng bd9d6c3
Merge branch 'main' into 4352_nd_unserialize_array
sreichel 9108f22
updated test result
sreichel c5edea4
Merge branch 'main' into 4352_nd_unserialize_array
sreichel af8bf19
Merge branch 'main' into 4352_nd_unserialize_array
sreichel d219722
sonar-1
sreichel 7cb2366
Merge remote-tracking branch 'kiatng/4352_nd_unserialize_array' into …
sreichel 20d73a9
Merge branch 'main' into 4352_nd_unserialize_array
sreichel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreichel In my test, line 34 is redundant. Why not remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested again, but w/o it you are passing null to unserialize.
Please revome it from PR and lets see what happens.