Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2: Added #[\SensitiveParameter] to all the codebase #4386

Closed
wants to merge 3 commits into from
Closed

PHP 8.2: Added #[\SensitiveParameter] to all the codebase #4386

wants to merge 3 commits into from

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Nov 26, 2024

Description (*)

Cherrypicked MahoCommerce/maho@891b27d and related commits

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes the Password Leak of UnserializeArray in Mage_Sales_Model_Quote_Item::compare causes exception and password leak #4383

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano, is that so okay?

@fballiano @Hanmac
PHP 8.2: Added #[\SensitiveParameter] to all the codebase
2864370 
# Conflicts:
#	.rector.php
@fballiano @Hanmac
Better rector configuration for SensitiveParameter
6efe5fb 
# Conflicts:
#	app/code/core/Mage/Api/Model/Server/Wsi/Handler.php
#	app/code/core/Mage/Sales/Model/Order/Invoice/Api/V2.php
@fballiano @Hanmac
Fixed docblock after SensitiveParameter
40b5c13
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Checkout Relates to Mage_Checkout Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Adminhtml Relates to Mage_Adminhtml Component: ProductAlert Relates to Mage_ProductAlert Component: Api PageRelates to Mage_Api Component: Admin Relates to Mage_Admin Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: ImportExport Relates to Mage_ImportExport rector labels Nov 26, 2024
@Hanmac
Copy link
Contributor Author

Hanmac commented Nov 26, 2024

ugh seems the tests still want PHP 7.4 :(

@sreichel
Copy link
Contributor

There is already a hidden PR to fix it for php7 too.

@sreichel sreichel mentioned this pull request Nov 26, 2024
Merged
@Hanmac
Copy link
Contributor Author

Hanmac commented Nov 27, 2024

Closed in favor of #4388

@Hanmac Hanmac closed this Nov 27, 2024
@Hanmac Hanmac deleted the pickSensitiveValue branch November 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: ImportExport Relates to Mage_ImportExport Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Sales Relates to Mage_Sales rector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hanmac @sreichel @fballiano