Fixed missing/wrong admin _setActiveMenu()
#4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: PayPal
kiatng
approved these changes
Sep 19, 2024
|
when you take PRs from other repos you should at least mention them: MahoCommerce/maho#12 @sreichel fo you remember that you were accusing somebody of this same thing? |
|
Dear @fballiano, these changes are based on this issue #4207 and aren't identical to yours. On your repo: +131 −110 lines changed Btw ... i can see a lot of "OM PR xyz" at https://github.com/MahoCommerce/maho/commits/main/. Have you left any credits? For sure i'll leave credits when I should pick up your or anybody else work. |
ADDISON74
approved these changes
Sep 19, 2024
|
Removed offtopic. Backuped screenshot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Some sections are not correctly highlighted when active.