Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnit: use database for tests, added tests #4138

Merged
merged 95 commits into from
Sep 17, 2024
Merged

PhpUnit: use database for tests, added tests #4138

merged 95 commits into from
Sep 17, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 2, 2024 •
edited
Loading

Description

  • install Openmage database for tests

GitHub workflow updates

  • merged phpunit and sonar, to not run tests twice
  • added unit-tests to php-cs-fixer/phpcs/phpstan checks

UnitTests

  • added tests from testfield
  • updated existing unit-tests
  • moved unit-tests to root directory
  • added composer scripts
  • added ~150 tests

Tests

composer run phpunit:test

or with covarge:

composer run phpunit:coverage

and with local html covarge: (view build/coverage/index.html)

composer run phpunit:coverage-local

@sreichel
Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)
3d7eaf6 
* Rector: CQ - UnusedForeachValueToArrayKeysRector

See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector

* fixes + phpstan

See fix at rector: rectorphp/rector-src#6164
@sreichel
Merge branch 'OpenMage:main' into main
53ee2f8
@sreichel
Merge branch 'OpenMage:main' into main
89cc37c
@sreichel
Merge branch 'OpenMage:main' into main
e939180
@sreichel
Merge branch 'OpenMage:main' into main
35c91ef
@sreichel
Updated test
abb5279
@sreichel
Added test
6aac86b
@sreichel
Added test
09ee18a
@sreichel
Renamed and updated test
40559cf
@sreichel
Updated test
18f1903
@sreichel
Updated test
cf4340d
@sreichel
Updated test
656044b
@sreichel
Updated test
b9630c1
@sreichel
Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)"
6f0b4b7 
This reverts commit 3d7eaf6.
@sreichel
Updated test (phpstan L9)
aa92e88
@sreichel
Updated test (fixed namespace)
f9e7b6f
@sreichel
Updated test (phpstan L9)
671107f
@sreichel
Added unit test to code style check and phpstan
475b8d4
@sreichel
Some cleanup
6d45ed6
@sreichel
Some cleanup
7f91768
@sreichel sreichel marked this pull request as draft August 2, 2024 22:35
@sreichel
Update
b0819e5 
- some tests commented - need files changes
@sreichel sreichel changed the title PhpUnit: added & update some tests PhpUnit: use database for tests, added tests Sep 4, 2024
ADDISON74
ADDISON74 previously approved these changes Sep 6, 2024
View reviewed changes
colinmollenhour
colinmollenhour previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

ADDISON74
ADDISON74 previously approved these changes Sep 9, 2024
View reviewed changes
@sreichel sreichel removed the request for review from mattdavenport September 9, 2024 22:57
@sreichel sreichel mentioned this pull request Sep 17, 2024
Merged
@sreichel sreichel merged commit 953920a into OpenMage:main Sep 17, 2024
20 checks passed
@sreichel sreichel deleted the unit-tests branch September 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

@mattdavenport mattdavenport Awaiting requested review from mattdavenport

Assignees
No one assigned
Labels
composer Relates to composer.json ddev environment php-cs-fixer phpcs phpstan phpunit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @kiatng @ADDISON74