Fixed an issue where dymos calling excessive allgathers during setup. #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during setup/configure.
| @@ -530,31 +506,42 @@ def _configure_parameters(self): | |||
|
|
|||
| def _configure_phase_options_dicts(self): | |||
| """ | |||
| Called during configure if we are under MPI. Loops over all phases and broadcasts the shape | |||
| and units options to all procs for all dymos variables. | |||
| Called during configure if we are under MPI. Loops over all phases and populates the | |||
There was a problem hiding this comment.
Isn't this called even if you aren't under MPI?
Kenneth-T-Moore
approved these changes
Sep 5, 2023
naylor-b
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dymos had been using allgather to collect units and shapes of variables for linkage calculations, and parameter information for trajectory parameters. These allgathers have been reduced to a single call at the start of the Trajectory configure process to pick up any variable information that was populated in the phases via introspection.
Related Issues
Backwards incompatibilities
None
New Dependencies
None