Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some issues that were causing simulation to fail under MPI. #978

Merged
merged 9 commits into from
Sep 5, 2023

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    e1f52a4 View commit details
    Browse the repository at this point in the history
  2. Fixed simulation under MPI.

    simulation was failing under MPI.
    - Setting simulation phase values from their source phases now accounts for MPI.
    - This code is built on the assumption that a phase and its corresponding simulation phase are on the same processor.
    - The trajectory created by `Trajectory.simulate` will not bother setting up linkages or interphase connections since they are irrelevant for simulation.
    - Bumped the minimum OpenMDAO version as specified in setup.py to 3.26.  We were already using this as the oldest supported version on CI.
    - In `set_vals_from_phase` for simulation phase we now don't grab variable values from their ultimate source (from_src=False).
    - The finite burn MPI test cases now include simulation.
    robfalck committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8e45252 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5a161f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a42d321 View commit details
    Browse the repository at this point in the history
  5. cleanup

    robfalck committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    922f94e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c35dfcb View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Added unit simplification to introspection when units involve multipl…

    …ication by time units.
    
    This prevents units such as '1/s*s' intead of None.
    
    Added a warnings context to simulation setup to ignore setup and unused options warnings that are not the fault of the user.
    robfalck committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c9c633d View commit details
    Browse the repository at this point in the history
  2. Cleaned up simulation phase so that state values can be pulled from e…

    …ither states or initial_states in the phase being simulated.
    robfalck committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    99932f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9885c1f View commit details
    Browse the repository at this point in the history