-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some issues that were causing simulation to fail under MPI. #978
Merged
Commits on Sep 1, 2023
-
working on simulation under mpi. works with linked phases but connect…
…ions problematic.
Configuration menu - View commit details
-
Copy full SHA for e1f52a4 - Browse repository at this point
Copy the full SHA e1f52a4View commit details -
simulation was failing under MPI. - Setting simulation phase values from their source phases now accounts for MPI. - This code is built on the assumption that a phase and its corresponding simulation phase are on the same processor. - The trajectory created by `Trajectory.simulate` will not bother setting up linkages or interphase connections since they are irrelevant for simulation. - Bumped the minimum OpenMDAO version as specified in setup.py to 3.26. We were already using this as the oldest supported version on CI. - In `set_vals_from_phase` for simulation phase we now don't grab variable values from their ultimate source (from_src=False). - The finite burn MPI test cases now include simulation.
Configuration menu - View commit details
-
Copy full SHA for 8e45252 - Browse repository at this point
Copy the full SHA 8e45252View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5a161f - Browse repository at this point
Copy the full SHA b5a161fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a42d321 - Browse repository at this point
Copy the full SHA a42d321View commit details -
Configuration menu - View commit details
-
Copy full SHA for 922f94e - Browse repository at this point
Copy the full SHA 922f94eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c35dfcb - Browse repository at this point
Copy the full SHA c35dfcbView commit details
Commits on Sep 5, 2023
-
Added unit simplification to introspection when units involve multipl…
…ication by time units. This prevents units such as '1/s*s' intead of None. Added a warnings context to simulation setup to ignore setup and unused options warnings that are not the fault of the user.
Configuration menu - View commit details
-
Copy full SHA for c9c633d - Browse repository at this point
Copy the full SHA c9c633dView commit details -
Cleaned up simulation phase so that state values can be pulled from e…
…ither states or initial_states in the phase being simulated.
Configuration menu - View commit details
-
Copy full SHA for 99932f4 - Browse repository at this point
Copy the full SHA 99932f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9885c1f - Browse repository at this point
Copy the full SHA 9885c1fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.