Fixes #337 - Command fix for project path with spaces #355
Conversation
Fix added for the command with space in dir.
src/util/commandUtils.ts
Outdated
|
|
||
| import * as Path from "path"; | ||
| import * as vscode from "vscode"; | ||
| import { isWin,mvnCmd,gradleCmd } from "../liberty/devCommands"; |
There was a problem hiding this comment.
What is the need to import methods isWin, mvnCmd and gradleCmd in commandUtils. These methods are never used in devCommands and elsewhere in the project. So in my suggestion you can remove these methods from devCommands and keep it in commandUtils. This can reduce one unnecessary import and improve performance.
There was a problem hiding this comment.
Comment incorporated. Moved unused methods from devCommands to commandUtils and removed import.
Thanks.
| * https://github.com/microsoft/vscode-maven/blob/main/src/mavenTerminal.ts | ||
| */ | ||
| function currentWindowsShell(): ShellType { | ||
| const currentWindowsShellPath: string = vscode.env.shell; |
There was a problem hiding this comment.
What does this return? Is it the default terminal or current terminal? What if there are multiple terminals opened in the vs code? Will it return the current terminal?
There was a problem hiding this comment.
It will return the default terminal details.
There was a problem hiding this comment.
Please confirm that we require the default terminal instead of current terminal.
There was a problem hiding this comment.
As per the existing behavior, even if we open multiple type of terminals in vscode, when we perform actions in liberty dashboard, commands will execute in the default terminal type. So we need to get default terminal details to decide the format of command.
TerminalBehavior.mov
src/util/commandUtils.ts
Outdated
| * Return the maven commands based on the OS and Terminal for start, startinContainer, start.. | ||
| */ | ||
|
|
||
| export async function getCommandForMaven(pomPath: string,command:string,customCommand?: string) : Promise<string> { |
There was a problem hiding this comment.
Fixed the indentation.
Thanks.
Fixes #337
Fix for the issue - 'No such file or directory' raised for the start, start in container and start .. action of LTV dashboard for a project opened from the directory with space and project name with space.