-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance artifact name #868 #873
Enhance artifact name #868 #873
Conversation
Hi @anusreelakshmi934 , this looks like a good start, but it only solves part of the issue described in #868.
We should change the LTI SHA in the artifact name to a branch/tag name as well. We may also want to consider having some sort of identifier for the project before the branch name to avoid confusion. The below may not be very clear:
Maybe we should try something like:
cc @mrglavas |
@TrevCraw I have modified it. Now the artifact name looks like below: Now I have given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact names look good. Thanks.
b34b7af
into
OpenLiberty:lsp4ij-market-0.0.2-integration
Fixes - Part of #868
The Artifacts will look like: