Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance artifact name #868 #873

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Jul 12, 2024

Fixes - Part of #868

The Artifacts will look like:
image

@TrevCraw
Copy link
Contributor

Hi @anusreelakshmi934 , this looks like a good start, but it only solves part of the issue described in #868.

It would be helpful for the consumer of these artifacts if the name included the PR number or branch (e.g. main) for LSP4iJ as well as the LTI branch (e.g. main) or tag (e.g. 24.0.12).

We should change the LTI SHA in the artifact name to a branch/tag name as well.

We may also want to consider having some sort of identifier for the project before the branch name to avoid confusion. The below may not be very clear:

  • liberty-tools-intellij-main-main
  • liberty-tools-intellij-main-PR-411
  • liberty-tools-intellij-24.0.6-main

Maybe we should try something like:

  • liberty-tools-intellij-lti:main-lsp4ij:main
  • liberty-tools-intellij-lti:main-lsp4ij:PR-411
  • liberty-tools-intellij-lti:24.0.6-lsp4ij:main

cc @mrglavas

@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Jul 15, 2024

Hi @anusreelakshmi934 , this looks like a good start, but it only solves part of the issue described in #868.

It would be helpful for the consumer of these artifacts if the name included the PR number or branch (e.g. main) for LSP4iJ as well as the LTI branch (e.g. main) or tag (e.g. 24.0.12).

We should change the LTI SHA in the artifact name to a branch/tag name as well.

We may also want to consider having some sort of identifier for the project before the branch name to avoid confusion. The below may not be very clear:

  • liberty-tools-intellij-main-main
  • liberty-tools-intellij-main-PR-411
  • liberty-tools-intellij-24.0.6-main

Maybe we should try something like:

  • liberty-tools-intellij-lti:main-lsp4ij:main
  • liberty-tools-intellij-lti:main-lsp4ij:PR-411
  • liberty-tools-intellij-lti:24.0.6-lsp4ij:main

cc @mrglavas

@TrevCraw I have modified it. Now the artifact name looks like below:
When running normal LTI build
image

When running cron Job:
image

Now I have given LTI-main hardcoded. Since i do not have the changes for running LSP4iJ continuous integration builds with existing LTI releases in my branch yet. So I guess once @vaisakhkannan 's PR is merged, we can specify LTI - against each tag similar to LSP4IJ.

Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact names look good. Thanks.

@anusreelakshmi934 anusreelakshmi934 merged commit b34b7af into OpenLiberty:lsp4ij-market-0.0.2-integration Jul 17, 2024
2 of 3 checks passed
@anusreelakshmi934 anusreelakshmi934 deleted the enhanceArtifactName#868 branch August 22, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants