Rename Artifact file and upgrade actions/upload-artifact version #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparnamichael
previously approved these changes
Jul 9, 2024
anusreelakshmi934
changed the title
|
https://github.com/anusreelakshmi934/liberty-tools-intellij/actions/runs/9859713253/job/27224116296 - Attaching the workflow run, here all the artifacts are uploaded with different names. https://github.com/anusreelakshmi934/liberty-tools-intellij/actions/runs/9853537694/attempts/1 - Shows workflow running against PR with conflict. Just to show the artifacts are uploaded against each PR differently. |
mrglavas
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Changes looks good. @anusreelakshmi934 @vaisakhkannan I opened a follow-up issue #868 to improve the name of the artifacts to make them easier for consumers to read. Didn't want to hold up this PR, so please go ahead and merge what you already have here.
anusreelakshmi934
merged commit b9e9f82
into
OpenLiberty:lsp4ij-market-0.0.2-integration
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #866 . Updated the upload-artifact version and also changed the file name of the artifact