Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the method suggestedName() used during config creation #1267

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

turkeylurkey
Copy link
Member

@turkeylurkey turkeylurkey commented Feb 11, 2025

The parent class already has a method to suggest a name. The new config mechanism calls this method when creating a config and also when cloning the config to detect changes while you type.

Fixes #180

This code suggests artifact id for Maven and directory name for Gradle.
image
image

Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@turkeylurkey turkeylurkey merged commit df572d1 into OpenLiberty:main Feb 13, 2025
4 checks passed
@turkeylurkey turkeylurkey deleted the issue-180 branch February 13, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run/Debug configuration name and project name populated up front
4 participants