Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the importProject using UI to utilize the IntelliJ API instead #1265

Open
wants to merge 2 commits into
base: intellij-2025.1-support
Choose a base branch
from
Open

Change the importProject using UI to utilize the IntelliJ API instead #1265

wants to merge 2 commits into from

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #1254

vaisakhkannan
vaisakhkannan reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you attach the recordings of this change that you tested locally.

@anusreelakshmi934
Copy link
Contributor Author

It would be better if you attach the recordings of this change that you tested locally.

Screen.Recording.2025-02-13.at.1.10.04.PM.mov

With this way, it doesnt utilize the UI. Instead it directly opens the required project.

vaisakhkannan
vaisakhkannan reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that spaces in directory names are opened correctly across all OS?

@anusreelakshmi934
Copy link
Contributor Author

Can you confirm that spaces in directory names are opened correctly across all OS?

As here in the build, we can see that the test is succeeding showing that the project is opened correctly.

vaisakhkannan
vaisakhkannan approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anusreelakshmi934 anusreelakshmi934 linked an issue Feb 14, 2025 that may be closed by this pull request
Change the Unstable UI to utilize the IntelliJ API instead. #1254
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaisakhkannan vaisakhkannan vaisakhkannan approved these changes

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

@dessina-devasia dessina-devasia Awaiting requested review from dessina-devasia

@mrglavas mrglavas Awaiting requested review from mrglavas

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the Unstable UI to utilize the IntelliJ API instead.
2 participants
@anusreelakshmi934 @vaisakhkannan