-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Found a possibility of limiting the Linux build only for the 24.0.9 LTI version #1218
base: main
Are you sure you want to change the base?
Changes from all commits
d9827c3
1877ee2
80d7536
c167b9e
9d7da0d
793314b
2e44d10
3950479
e6a99ee
48195d9
a3cc10c
88f7f41
fc4a3a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,21 +92,34 @@ jobs: | |
|
||
build: | ||
needs: fetch_merge_commit_sha_from_lsp4ij_PR | ||
runs-on: ${{ matrix.os }} | ||
name: build ( ${{ matrix.runtime.name }}, ${{ matrix.excludeLTITag }} ) | ||
runs-on: ${{ matrix.runtime.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
runtime: [ linux, mac, windows ] | ||
include: | ||
- runtime: linux | ||
runtime: | ||
- name: linux | ||
os: ubuntu-latest | ||
reportName: linux-test-report | ||
- runtime: mac | ||
- name: mac | ||
os: macOS-latest | ||
reportName: mac-test-report | ||
- runtime: windows | ||
- name: windows | ||
os: windows-latest | ||
reportName: windows-test-report | ||
# It’s not necessary to remove the below condition even after removing the '24.0.9' version from the 'tag' array in the cron job build. | ||
# Specify the LTI tag to limit the OS. | ||
# Adding a check to verify if 'refLTITag' is equal to '24.0.9'. | ||
excludeLTITag: | ||
- ${{ inputs.refLTITag == '24.0.9' }} | ||
# Adding a check on macOS and Windows to verify if 'excludeLTITag' is equal to 'true'. The value of 'excludeLTITag' is used to determine whether the job need to be executed. | ||
exclude: | ||
- excludeLTITag: true | ||
runtime: | ||
name: mac | ||
- excludeLTITag: true | ||
runtime: | ||
name: windows | ||
env: | ||
USE_LOCAL_PLUGIN: ${{ inputs.useLocalPlugin || false }} | ||
REF_LSP4IJ: ${{ needs.fetch_merge_commit_sha_from_lsp4ij_PR.outputs.pr_details }} | ||
|
@@ -168,6 +181,6 @@ jobs: | |
if: ${{ failure() && steps.run_tests.conclusion == 'failure' }} | ||
uses: actions/[email protected] | ||
with: | ||
name: ${{ matrix.reportName }}-LTI-${{ env.REF_LTI_TAG || 'default' }}-LSP4IJ-${{ env.LSP4IJ_BRANCH || 'default' }} | ||
name: ${{ matrix.runtime.reportName }}-LTI-${{ env.REF_LTI_TAG || 'default' }}-LSP4IJ-${{ env.LSP4IJ_BRANCH || 'default' }} | ||
path: | | ||
liberty-tools-intellij/build/reports/ | ||
liberty-tools-intellij/build/reports/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change in this section, seems an extra line added here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like there is a bug from GitHub, I could not see an extra line. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Most likely you added a carriage return at the end of the line. Or removed one. It is highly unlikely there is a bug with github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaisakhkannan Can you explain the reason of adding runtime here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dessina-devasia , There is a change in the matrix strategy with this PR.
Previously, the code was:
With this PR, the goal is to retrieve the unique
reportName
using only viamatrix.runtime.reportName
.