Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistenceMapKeyDiagnosticsCollector: Move body of the for loops over methods and fields into a common method. #1037

Merged
merged 3 commits into from
Oct 29, 2024
Merged

PersistenceMapKeyDiagnosticsCollector: Move body of the for loops over methods and fields into a common method. #1037

merged 3 commits into from
Oct 29, 2024

Conversation

mrglavas
Copy link
Contributor

Resolves #1024

@mrglavas mrglavas self-assigned this Oct 18, 2024
@mrglavas
Removing an unused field.
3ac1660 
Signed-off-by: Michael Glavassevich <[email protected]>
turkeylurkey
turkeylurkey previously approved these changes Oct 18, 2024
View reviewed changes
@mrglavas
Copy link
Contributor Author

@TrevCraw @turkeylurkey I've updated the PR as per our discussion today. Can you review again?

TrevCraw
TrevCraw approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mrglavas.

Please also make sure to open the issues we discussed:

  1. Are we looping through a correct set of methods?
  2. Are the constraints being checked here correct?

@mrglavas
Copy link
Contributor Author

Looks good, thanks @mrglavas.

Please also make sure to open the issues we discussed:

1. Are we looping through a correct set of methods?

2. Are the constraints being checked here correct?

Yes, on my TODO list to open against https://github.com/eclipse/lsp4jakarta.

@mrglavas mrglavas merged commit 7c8b0de into OpenLiberty:main Oct 29, 2024
1 of 3 checks passed
@mrglavas mrglavas deleted the 1024#reduce-code-duplication branch October 29, 2024 05:24
This was referenced Oct 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkeylurkey turkeylurkey turkeylurkey approved these changes

@TrevCraw TrevCraw TrevCraw approved these changes

@aparnamichael aparnamichael Awaiting requested review from aparnamichael

Assignees

@mrglavas mrglavas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce code duplication in PersistenceMapKeyDiagnosticsCollector.
3 participants
@mrglavas @TrevCraw @turkeylurkey