Wait after clicking button to open window #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
TrevCraw
reviewed
Oct 25, 2024
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
|
Check out the comments. |
|
@turkeylurkey all 3 builds are failing - is it all known failures? |
mrglavas
approved these changes
Oct 28, 2024
|
Linux: error starting server. |
aparnamichael
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First we try to find the window and then if it is closed we click on the button to open it. But if the window does not open right away on a slow machine then the next time we repeat this action we will click a second time and end up closing the window we want open. So add a short delay after we click. Also added is a slightly longer delay before we try to look for the window in case a previous operation is still running.
I believe one of the exceptions listed in the issue is caused by the problem of the first exception:
Exceeded timeout ... Failed to find 'Welcome Frame'Fixes #971