Skip to content

add OCP SCC info #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

add OCP SCC info #7119

merged 1 commit into from
Dec 7, 2023

Conversation

dmuelle
Copy link
Member

@dmuelle dmuelle commented Dec 7, 2023

@dmuelle dmuelle merged commit f8d637b into draft Dec 7, 2023
@@ -338,6 +338,36 @@ When you deploy to Kubernetes, the container must be granted the `CHECKPOINT_RES
- ALL
----

==== Red Hat OpenShift security context constraints

To deploy applications to Red Hat OpenShift with InstantOn, you must specify a security context constraint (SCC) that at a minimum grants the capabilities to the defaults that are needed for InstantOn. The following example defines an SCC with these capabilities that is called `defaultAddCapabilities`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read right to me.

that at a minimum grants the capabilities to the defaults that are needed for InstantOn.

The capabilities listed under defaultAddCapabilities are adding the capabilities to the set of capabilities which are granted to any pod. So it is adding capabilities to that list of default capabilities. To me it would make more sense to read like this:

that at a minimum specifies a list of additional capabilities that are added to any pod. The following example defines an SCC with the required capabilities by using the parameter called defaultAddCapabilities:

- SETPCAP
----

The applications you deploy must be associated with this SCC, for example, by specifying the `serviceAccountName` setting in the deployment yaml file. The following example specifies the `defaultAddCapabilities` SCC that was defined in the previous example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing because defaultAddCapabilities is treated as if it is an SCC name, but before defaultAddCapabilities is a parameter of the SCC yaml file. I think it would be better to use a name like liberty-instanton-scc:

The applications you deploy must be associated with an SCC that adds the required capabilities. For example, assume there is an SCC deployed called liberty-instanton-scc that added the required capabilities. The following example specifies the serviceAccountName parameter to set the SCC name to liberty-instanton-scc:


[source,yaml]
----
serviceAccountName: defaultAddCapabilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to:

  serviceAccountName: liberty-instanton-scc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants