Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle change in installDir between dev mode runs #879

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

cherylking
Copy link
Member

Addresses scenario 1 in issue #878

@cherylking
Copy link
Member Author

I did not update any tests for this since automated dev mode tests are somewhat fragile. I did the following manual tests using the guide-getting-started.

  1. Configured the following in build.gradle: libertyRuntime group: 'io.openliberty', name: 'openliberty-kernel', version: '23.0.0.12'
  2. Ran gradle libertyDev -i -s.
  3. Once the app was up, stopped dev mode with q.
  4. Ran gradle --stop
  5. Checked the contents of liberty-plugin-config.xml for correct installDirectory, assemblyArtifact and assemblyArchive. Also checked paths for the various server related dirs to ensure they were same path as installDirectory.
  6. Added the following to build.gradle:
liberty {
   installDir = "/Users/cherylking/liberty-23009/wlp"
}
  1. Ran gradle libertyDev -i -s.
  2. Once the app was up, stopped dev mode with q.
  3. Ran gradle --stop
  4. Checked the contents of liberty-plugin-config.xml for correct installDirectory and NO assemblyArtifact or assemblyArchive. Also checked paths for the various server related dirs to ensure they were same path as installDirectory.
  5. Deleted the build folder to start fresh.
  6. Ran gradle libertyDev -i -s again.
  7. Once the app was up, stopped dev mode with q.
  8. Ran gradle --stop
  9. Checked the contents of liberty-plugin-config.xml for correct installDirectory and NO assemblyArtifact or assemblyArchive. Also checked paths for the various server related dirs to ensure they were same path as installDirectory.

@cherylking cherylking merged commit a3bbd39 into OpenLiberty:main Feb 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants