Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slave skills #3914

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix slave skills #3914

merged 2 commits into from
Dec 26, 2024

Conversation

Henrybk
Copy link
Contributor

@Henrybk Henrybk commented Dec 23, 2024

Fixes #3913

Each actor now holds their own skill list.

Possible problem is that I don't know actually how skills are handled in the server, if they are coded as a character skill then their use must remain in AI::Corelogic, if however slaves are their own separate entity with cooldowns of their own then it would probably be wise to move their skill usage to their AI.

58121ea4deb7469df1977f96e9d7dff3

EDIT:
It does seem char and slave are completely independent, I'll move the skill use logic to their AI

EDIT2:
Done, just gotta test it

Edit 3:

Video showing it working:
Youtube

@Henrybk
Copy link
Contributor Author

Henrybk commented Dec 24, 2024

Tested both mercenary and homunculus for about 4 hours each, using both basic attacks and attack skills, got no errors during that time, I believe this is safe for merge.

During testing however I noticed that in new clients the server not always sends the proper packets for homunculus info, which can lead to crashes, in my testing that happens only when homunculus is dead and you interact with another slave however.
I will try to fix that also but it is beyond the scope of this pull request.

Also, in the future I will move slave selfskills to their AI in another PR.

Copy link
Contributor

@alisonrag alisonrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Henrybk Henrybk merged commit 6a1c6a2 into master Dec 26, 2024
9 checks passed
@Henrybk Henrybk deleted the Fixslaveskills branch December 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homunculus skills not working
2 participants