Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame barrier logic alpha showcase #3906

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Henrybk
Copy link
Contributor

@Henrybk Henrybk commented Dec 17, 2024

OK so this is much more of a showcase of a project I had last year (or was it 2022?) than a pull request.
I decided to put this in here in case someone finds it interesting and decides to test/help/develop in the future.

Video showcase

The code is full of typos and unedited comments and config edits, as I said, more of a showcase.

Can be closed if wanted.

@ya4ept
Copy link
Contributor

ya4ept commented Dec 17, 2024

looks interesting, thanks.
I wonder if it can be made into a separate plugin, without editing the main code?

@Henrybk
Copy link
Contributor Author

Henrybk commented Dec 17, 2024

looks interesting, thanks.

I wonder if it can be made into a separate plugin, without editing the main code?

I believe it could be done but it would require a refactor of the Attack code to use many consecutive checks interposed with hook calls instead of a elsif chain like it is done today.

Something like:
Callhook (attack1)
If (foo) { Run }

Callhook (attack2)
If (bar) { Attack }

Much like buyauto/sellauto works

@ya4ept
Copy link
Contributor

ya4ept commented Dec 17, 2024

If you add this code to the main branch, you can make it more versatile. For example, you can use the trap skill

@Henrybk
Copy link
Contributor Author

Henrybk commented Dec 19, 2024

As soon as Path v3 is done and merged I will try to convert this one to plugin form then

@Henrybk Henrybk marked this pull request as draft December 28, 2024 16:39
@Henrybk Henrybk self-assigned this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants