attack improve code

OpenKore · Sep 17, 2024 · 144f0b5 · 144f0b5
1 parent 726a805
commit 144f0b5
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/AI/Attack.pm b/src/AI/Attack.pm
@@ -39,11 +39,7 @@ sub process {
 	Benchmark::begin("ai_attack") if DEBUG;
 	my $args = AI::args;
 
-	if (
-		   (AI::action eq "attack" && $args->{ID})
-		|| (AI::action eq "route" && AI::action (1) eq "attack" && $args->{attackID})
-		|| (AI::action eq "move" && AI::action (2) eq "attack" && $args->{attackID})
-	) {
+	if (shouldAttack($action, $args)) {
 		my $ID;
 		my $ataqArgs;
 		if (AI::action eq "attack") {
@@ -205,6 +201,15 @@ sub process {
 	Benchmark::end("ai_attack") if DEBUG;
 }
 
+sub shouldAttack {
+    my ($action, $args) = @_;
+    return (
+        ($action eq "attack" && $args->{ID})
+        || ($action eq "route" && AI::action(1) eq "attack" && $args->{attackID})
+        || ($action eq "move" && AI::action(2) eq "attack" && $args->{attackID})
+    );
+}
+
 sub shouldGiveUp {
 	my ($args, $ID) = @_;
 	return !$config{attackNoGiveup} && (timeOut($args->{ai_attack_giveup}) || $args->{unstuck}{count} > 5);