Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for DPT 24.* and DPT 28.*. #24

Closed
wants to merge 3 commits into from

Conversation

ab-tools
Copy link

@ab-tools ab-tools commented May 5, 2024

No description provided.

@ab-tools
Copy link
Author

ab-tools commented May 5, 2024

Another question, noticed while working on this:
What is the reason that signed8FromPayload is used for 14 byte strings here instead of unsigned8FromPayload?
https://github.com/OpenKNX/knx/blob/v1/src/knx/dptconvert.cpp#L524

This is even more strange as unsigned8ToPayload is used for the opposite conversion direction:
https://github.com/OpenKNX/knx/blob/v1/src/knx/dptconvert.cpp#L1196

Is there a specific reason for this or a bug that should be fixed?

@Ing-Dom
Copy link
Member

Ing-Dom commented May 18, 2024

please change your PR to merge into v1dev instead of v1

@ab-tools ab-tools changed the base branch from v1 to v1dev May 18, 2024 08:05
@ab-tools
Copy link
Author

Sure, done.

@Ing-Dom
Copy link
Member

Ing-Dom commented May 18, 2024

thx. and please merge the latest v1dev to your feature branch then the checks should all be ok

@ab-tools
Copy link
Author

Done as well.

@ab-tools
Copy link
Author

Will create new PR, when ready - as discussed in Slack.

@ab-tools ab-tools closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants