Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-make: update to 4.4.1; drop 32 bit #20532

Draft
wants to merge 1 commit into
base: oi/hipster
Choose a base branch
from

Conversation

mtelka
Copy link
Contributor

@mtelka mtelka commented Jan 23, 2025

No description provided.

@AndWac
Copy link
Contributor

AndWac commented Jan 23, 2025

I have installed this on a second system with the same results:
╰─➤ gmake setup
/bin/sh: git: not found [No such file or directory]
/bin/bash: line 1: uname: command not found
make-rules/shared-macros.mk:140: /make-rules/ips-buildinfo.mk: No such file or directory
gmake: *** No rule to make target '/make-rules/ips-buildinfo.mk'. Stop.

The new make version seem to have problems with its environment. I don't know what makes my installations special as I try to be as close as possible to the build server. So I expect similar problems when I merge this PR.

@mtelka
Copy link
Contributor Author

mtelka commented Jan 23, 2025

@AndWac please paste output from following commands:

pwd
pkg list -afv gnu-make
gmake --version
git rev-parse HEAD
git status
env - gmake setup

@mtelka
Copy link
Contributor Author

mtelka commented Jan 23, 2025

Okay, I reproduced the problem. When gmake is run without env - then it fails here too. Investigating...

@mtelka
Copy link
Contributor Author

mtelka commented Jan 23, 2025

It looks like the following change introduced in GNU make 4.4 is causing the problem:

* WARNING: Backward-incompatibility!
  Previously makefile variables marked as export were not exported to commands
  started by the $(shell ...) function.  Now, all exported variables are
  exported to $(shell ...).  If this leads to recursion during expansion, then
  for backward-compatibility the value from the original environment is used.
  To detect this change search for 'shell-export' in the .FEATURES variable.

Namely, the problem is with the PATH variable.

To solve the problem we need some changes and cleanups in our Makefiles. Until they are implemented I'll convert this PR to draft.

@mtelka mtelka marked this pull request as draft January 23, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants