Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensmalltalk cog-spur: set GCC_VERSION=13 #20496

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

cstes
Copy link
Collaborator

@cstes cstes commented Jan 19, 2025

This version of OpenSmalltalk Cog Spur runs Cuis Smalltalk,
and it also runs Squeak 6.1alpha 64bit

However when running the SUnit tests it fails on
MCMczInstallerTest test suite.

I'll raise an OpenSmalltalk issue for that SUnit failure for the MczInstaller (which is meant to load the chunk-format code inside an mcz archive without using the normal Monticello machinery).

@cstes
Copy link
Collaborator Author

cstes commented Jan 19, 2025

Actually before raising an OpenSmalltalk issue for this, I'll do some more debugging myself. I think the Squeak community considers the OpenIndiana version of OpenSmalltalk as something unsupported by Squeak anyway ...

@cstes
Copy link
Collaborator Author

cstes commented Jan 20, 2025

When I use the command "inisqueak" (which is a script that will download and create a Smalltalk Squeak VM in the current directory) it downloads the older 5.3 64bit image (update 19486) and the SUnit tests for that version (5.3) works fine with this version of cog-spur (compiled with gcc 13.3). It runs 4735 tests and for me 4688 tests pass. There were a few BitmapStreamTest failures for me but I think these could be normal. Note that the older Squeak 5.3 image is a 68021 Smalltalk image and not a 68533 SistaV1 image like the Squeak 6.1alpha image where I noticed a SUnit failure on MCMczInstallerTest . Anyway, this version of cog-spur is as good as any of the older versions of cog-spur packaged for OpenIndiana. Regarding the C compiler gcc 14.2, I think noone so far has compiled OpenSmalltalk with gcc 14.2, but in the following weeks I'll give it a try when I update the cog-spur again, and move the package to gcc 14.2.

@AndWac
Copy link
Contributor

AndWac commented Jan 22, 2025

You can silence gcc-14 with these lines:

gcc 14 complains about this

CFLAGS += -Wno-error=implicit-function-declaration
CFLAGS += -Wno-error=incompatible-pointer-types
CFLAGS += -Wno-error=return-mismatch

@mtelka
Copy link
Contributor

mtelka commented Jan 22, 2025

@cstes please report this upstream and add link to the bug report into the Makefile as a comment. Thank you.

@AndWac AndWac merged commit 1a9e956 into OpenIndiana:oi/hipster Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants