forked from openstreetmap/iD
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EDTF start and end date fields #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-edtf-fields-645
branch
from
December 16, 2023 20:20
1425220
to
eddb334
Compare
1ec5
force-pushed
the
1ec5-edtf-fields-645
branch
from
December 17, 2023 06:57
6aa4293
to
6f12efd
Compare
1ec5
force-pushed
the
1ec5-date-field-644
branch
from
December 17, 2023 07:03
cba209e
to
4e338f3
Compare
Removed the separate fields for the start_date:edtf and end_date:edtf keys in favor of extending the date field type to manage *:edtf subkeys in the same manner that a localized field type manages language subkeys.
1ec5
force-pushed
the
1ec5-edtf-fields-645
branch
from
December 17, 2023 07:04
6f12efd
to
b4f6126
Compare
This was referenced Jan 5, 2024
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Start Date (EDTF) and End Date (EDTF) fields that automatically appear beneath the Start Date and End Date fields when the corresponding non-EDTF field is filled in.
Outdated screenshot
This is just a plain field. Future enhancements can be tracked separately. For example, we could consolidate the EDTF fields with the Start Date and End Date fields, having them appear only when clicking the ➕ button, similar to how the localized name fields work. We can also implement validation and human-readable suggestions as a follow-up.✔️Fixes OpenHistoricalMap/issues#645. Depends on #185.