Improve tile overlap. #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common tile server with overlapping tiles is deep zoom. Tiles in the center of the image have overlap on all four sides, but tiles at the edges don't overlap past the conceptual image space. We properly handled the right and bottom, but the top and left edges were expecting tiles that were larger than deep zoom was providing. For instance, a 256x256 tile with an overlap of 1 produces a 258x258 tile in the center, but a 257x257 tile at the upper left and a 257x258 else on the left edge. This handles those properly. The deepzoom example also maintains query parameters, making it easier to modify for testing.
aashish24
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common tile server with overlapping tiles is deep zoom. Tiles in the center of the image have overlap on all four sides, but tiles at the edges don't overlap past the conceptual image space. We properly handled the right and bottom, but the top and left edges were expecting tiles that were larger than deep zoom was providing. For instance, a 256x256 tile with an overlap of 1 produces a 258x258 tile in the center, but a 257x257 tile at the upper left and a 257x258 else on the left edge. This handles those properly.
The deepzoom example also maintains query parameters, making it easier to modify for testing.