Test layer.js. #949
Merged
Test layer.js. #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the layer specification to a typedef for better documentation. Make sure all layer types use typedefs. Fix issues with the layer id function. Ensures that canvas and renderer can actually be specified when creating a layer. This allows layers to share a renderer or a canvas. For the webgl renderer, sharing a canvas results in flashing, as each layer completely redraws the canvas. When sharing a renderer, there is no proper support for opacity (probably not for visibility) or z-order, but this is a first step to implementing #942. Removed some unused code.
zachmullen
reviewed
Nov 2, 2018
zachmullen
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the layer specification to a typedef for better documentation. Make sure all layer types use typedefs.
Fix issues with the layer id function.
Ensures that canvas and renderer can actually be specified when creating a layer. This allows layers to share a renderer or a canvas. For the webgl renderer, sharing a canvas results in flashing, as each layer completely redraws the canvas. When sharing a renderer, there is no proper support for opacity (probably not for visibility) or z-order, but this is a first step to implementing #942.
Removed some unused code.