Optimize coordinate transforms on flat arrays. #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
optimize-flat-array-transform
branch
from
b4c267c to
43c2233
Compare
This is commonly done (for instance in generating glLineFeature). As a crude metric, this reduces time by about a third. For instance, transforming ~100,000 line vertices went from around 60 ms to 40 ms.
manthey
force-pushed
the
optimize-flat-array-transform
branch
from
43c2233 to
8cd7896
Compare
aashish24
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is commonly done (for instance in generating glLineFeature). As a crude metric, this reduces time by about a third. For instance, transforming ~100,000 line vertices went from around 60 ms to 40 ms.