Reduced use of the vgl module. #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
reduce-vgl-use
branch
from
c768d08 to
283faa8
Compare
The `object` and `timestamp` classes were using the vgl module definitions of these as base classes. This obscured documentation -- the `modified` and `getMTime` methods were not in the geojs code, and therefore did not appear in the jsdocs. Rather than artificially inject it, this simplifies code to move that functionality to the geojs repo. This means that only the gl renderer has any dependency on the vgl module (except fir the clustering code, which needs to be refactored in any case). As part of this, `getMTime` was renamed to the somewhat less obscure `timestamp`. The old name is still supported, but not in the jsdoc (it wasn't in the jsdoc before, either). This also converts all uses of `new Date().getTime()` to `Date.now()`.
manthey
force-pushed
the
reduce-vgl-use
branch
from
283faa8 to
d3b2e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
objectandtimestampclasses were using the vgl module definitions of these as base classes. This obscured documentation -- themodifiedandgetMTimemethods were not in the geojs code, and therefore did not appear in the jsdocs. Rather than artificially inject it, this simplifies code to move that functionality to the geojs repo. This means that only the gl renderer has any dependency on the vgl module (except fir the clustering code, which needs to be refactored in any case).As part of this,
getMTimewas renamed to the somewhat less obscuretimestamp. The old name is still supported, but not in the jsdoc (it wasn't in the jsdoc before, either).This also converts all uses of
new Date().getTime()toDate.now().