Allow adjusting camera clipbounds. #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was motivated by wanting to set the near and far clip values. This
can be done by `map.camera().clipbounds = {near: <near value>, far: <far
value>}`.
This simplifies some of the camera code. Before, we were generating a
display matrix but separately calculating the transform in a series of
steps, and similarly we were doing the inverse via a set of steps
instead of a matrix multiplication. This uses the `display` and `world`
matrices explicitly in the transforms.
The `css` transform property was ambiguous about the transform origin.
We now explicitly expect a transform-origin of `0 0`, as we use that
elsewhere in the project. This adjusts several tests.
Some of the tests have be rewritten for clarity.
Some of the camera helper functions have been eliminated as they were
simple wrappers around matrix functions.
There are now distinct clipbounds for perspective and parallel
projections.
The css transform format was rewritten to be more compact and not lose
precision in some instances.
Note that the webgl use of the perspective camera projection will need
additional refactoring to handle any clipbounds.
manthey
force-pushed
the
camera-clipbounds
branch
from
30d2ec8 to
3075e87
Compare
aashish24
reviewed
Aug 21, 2018
| far: -2, | ||
| near: -1 | ||
| camera.clipbounds = { | ||
| perspective: { |
There was a problem hiding this comment.
typically for perspective, you use angle, aspect and near far only (e.g. see here: http://www.ntu.edu.sg/home/ehchua/programming/opengl/CG_examples.html). I think setting in terms of gcs bounds is also useful so perhaps we are fine for now.
There was a problem hiding this comment.
I fully expect that the perspective mode will change further when we start using it in earnest.
aashish24
approved these changes
Aug 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was motivated by wanting to set the near and far clip values. This can be done by
map.camera().clipbounds = {near: <near value>, far: <far value>}.This simplifies some of the camera code. Before, we were generating a display matrix but separately calculating the transform in a series of steps, and similarly we were doing the inverse via a set of steps instead of a matrix multiplication. This uses the
displayandworldmatrices explicitly in the transforms.The
csstransform property was ambiguous about the transform origin. We now explicitly expect a transform-origin of0 0, as we use that elsewhere in the project. This adjusts several tests.Some of the tests have be rewritten for clarity.
Some of the camera helper functions have been eliminated as they were simple wrappers around matrix functions.
There are now distinct clipbounds for perspective and parallel projections.
The css transform format was rewritten to be more compact and not lose precision in some instances.
Note that the webgl use of the perspective camera projection will need additional refactoring to handle any clipbounds.