Build two bundles: full and lean #890
Conversation
The lean bundle does not include any of the runtime packages (currently just hammerjs and d3) and assumes they'll be available at runtime in the global namespace.
|
@zachmullen This looks like a fine start. @jbeezley Do you know what determines which files go to the CloudFlare CDN? |
|
https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/geojs/package.json I don't remember exactly how it works, but any changes would have to be made as a PR to this file. |
zachmullen
changed the title
|
@manthey PTAL, I think this is ready for final review. |
CHANGELOG.md
Outdated
| @@ -43,6 +43,7 @@ | |||
| - Remove bower support (#856) | |||
| - Switch to webpack v3 (#854) | |||
| - Removed needless function wrappers (#870) | |||
| - Changed build process: optional dependencies are now included in the bundle by default (#890) | |||
There was a problem hiding this comment.
This will be released in the next version, so can you add an ## Unreleased section to the change log and move it to within that?
| <script type="text/javascript" src="../../built/geo.min.js"></script> | ||
| <!-- Use a specific version of GeoJS by requesting it from a CDN. | ||
| For instance, remove the local references, above, and | ||
| uncomment the following: | ||
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/geojs/0.15.1/geo.ext.min.js"></script> |
There was a problem hiding this comment.
We'll release the changed build as next next version (0.18.0). Since older version on the CDN would still need the geo.ext.js script from older versions, lets change the version for geo.min.js.
|
@zachmullen this is super nice improvement.. 👍 |
@manthey @aashish24 this first commit represents the build configuration changes we discussed yesterday. If you approve of these changes, I'll go through and change the website and examples code.