Improve line updates #779
Merged
Improve line updates #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct some minor issues with docs for the polygon feature.
Before, any change to a line style would recompute the geometry information as well. Now, if the position of vertices has not changes, the geometry is not recomputed. Further, many style were being called by function when they were their default values (such as the strokeOffset not being set). These properly are treated as fixed values, avoiding many function calls. The polygon feature, when stroked, is better at passing constant values for stroke opacity to the lines. In practice, this results in a large speed up. For a condition where there are lines with ~100,000 vertices, the line _build call was reduced from 450-500 ms to 12-15 ms.
|
@kheffah: This resolves a performance issue reported in DigitalSlideArchive/HistomicsTK#459. |
Some code was in a loop that should have been out of it. This adds a test for the correct behavior. Also, if a polygon is degenerate, it should not generate stroke information.
aashish24
reviewed
Feb 28, 2018
| return m_this.style.get('stroke')(d[2], d[3]) ? m_this.style.get('strokeOpacity')(d[0], d[1], d[2], d[3]) : 0; | ||
| } | ||
| strokeOpacity: util.isFunction(polyStyle.stroke) || !polyStyle.stroke ? | ||
| function (d) { |
aashish24
reviewed
Feb 28, 2018
| */ | ||
| this._build = function () { | ||
| createGLLines(); | ||
| createGLLines(m_this.dataTime().getMTime() < m_this.buildTime().getMTime() && m_geometry); |
Fix a bug in pointSearch on closed lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up line style updates.
Before, any change to a line style would recompute the geometry information as well. Now, if the position of vertices has not changes, the geometry is not recomputed. Further, many style were being called by function when they were their default values (such as the strokeOffset not being set). These properly are treated as fixed values, avoiding many function calls. The polygon feature, when stroked, is better at passing constant values for stroke opacity to the lines.
In practice, this results in a large speed up. For a condition where there are lines with ~100,000 vertices, the line _build call was reduced from 450-500 ms to 12-15 ms.