Improve resolving optional dependencies. #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack makes any dependency that is not in a try-catch block a required dependency. Adjust code to be in conformance with this. All require statements for `d3` and `hammerjs` are now guarded. Most `d3` references are now via `d3Renderer.d3` to avoid having to have conditionals in every file.
aashish24
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack makes any dependency that is not in a try-catch block a required dependency. Adjust code to be in conformance with this. All require statements for
d3andhammerjsare now guarded. Mostd3references are now viad3Renderer.d3to avoid having to have conditionals in every file.