Use the average perimeter as the center of a polygon or line. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewma7 Would this be useful as a stand-alone function in utils? It could be named something like |
|
@manthey Yes, I think this could be useful, at this moment I have a use case for it. |
When a polygon has many points near each other in one area and few along the opposite part of the perimeter, this produces a nicer center.
Add more tests.
manthey
force-pushed
the
center-of-polygon
branch
from
42d552f to
bff9e1a
Compare
This removes the burden on binding events to the class instance.
Merged
aashish24
reviewed
Feb 3, 2018
| * @returns {geo.geoPosition|undefined} The position for the center, or | ||
| * `undefined` if no such position exists. | ||
| */ | ||
| centerFromPerimeter: function (coor) { |
There was a problem hiding this comment.
@manthey it would be good to describe the math in words to explain what is done in this snippet.
There was a problem hiding this comment.
@aashish24 I added a bit more to the function comment.
Shift many references in annotations code of this to m_this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a polygon has many points near each other in one area and few along the opposite part of the perimeter, this produces a nicer center.