Don't automatically install website node modules. #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When geojs is used as a node module in another project, we should install all of the website's node modules. Doing so bloats the deployment directory of other projects. This should be a safe change unless we expect other projects to use the generated geojs website as components within those projects. This skips installing 10,000 files that total 76 Mb.
|
@matthewma7 I don't think harms anything. |
matthewma7
approved these changes
Dec 7, 2017
There was a problem hiding this comment.
@manthey Totally, I didn't take that effect of postinstall into consideration. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geojs is used as a node module in another project, we should install all of the website's node modules. Doing so bloats the deployment directory of other projects. This should be a safe change unless we expect other projects to use the generated geojs website as components within those projects.
This skips installing 10,000 files that total 76 Mb.