Add video quads #745
Merged
Add video quads #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update some renderer documentation.
Don't test video in PhantomJS. Allow console.log messages to appear in tutorial test output.
Video quads are currently only supported by the canvas renderer. If the video is not ready, a preview color can be shown, but not a preview image. Added color quads to the canvas renderer. This made things easier to test. Improved some of the caching logic in quads to reduce reloading images and videos in some circumstances. Added a utility method to invalidate one or all of the quad's caches. This removes using a private method in the quad example. Added code to defer rendering if something is busy. This prevents flashing when seeking on a playing video. Fixed an issue with the canvas transform on images and videos.
Add a video to the quads example. Add two video quad tutorials; one stand-alone quad and one quad positioned on a map.
|
This PR is broken into separate commits to try to make it easier to review. |
aashish24
reviewed
Nov 9, 2017
src/canvas/canvasRenderer.js
Outdated
| @@ -111,6 +111,13 @@ var canvasRenderer = function (arg) { | |||
| features = layer.features(), | |||
| i; | |||
|
|
|||
| for (i = 0; i < features.length; i += 1) { | |||
| if (features[i]._delayRender()) { | |||
There was a problem hiding this comment.
should it be if (!features[i]._delayRender())? If delayRender is true which means you want to skip rendering or something I missed here?
There was a problem hiding this comment.
Calling render() reschedules the rendering to the next animation frame. The return then stops it from rendering right now.
There was a problem hiding this comment.
ok, thanks perhaps adding a comment here might help but I am fine either way.
aashish24
reviewed
Nov 10, 2017
src/canvas/quadFeature.js
Outdated
| this._renderImageQuads = function (context2d, map) { | ||
| if (!m_quads.imgQuads.length) { | ||
| this._renderImageAndVideoQuads = function (context2d, map) { | ||
| if ((!m_quads.imgQuads || !m_quads.imgQuads.length) && (!m_quads.vidQuads || !m_quads.vidQuads.length)) { |
Update a minor spacing issue in the comments of the single video tutorial and update its thumbnail to match.
aashish24
reviewed
Nov 14, 2017
src/quadFeature.js
Outdated
| return m_quads; | ||
| }; | ||
|
|
||
| /** | ||
| * Initialize | ||
| * If the data has changed and caching has been used, one or all data items |
There was a problem hiding this comment.
this sentence seems incomplete or missing some words?
aashish24
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video quads are currently only supported by the canvas renderer. If the video is not ready, a preview color can be shown, but not a preview image (to show a preview image, create an image quad at the same coordinates as the video quad).