Update examples. #743
Merged
Update examples. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak a few examples to fix some inconsistencies and errors. The goal is for every example to start in an interesting spot, and, moreover, for the thumbnail of the example to be representative of the example. Added an optional `thumbquery` parameter to example.json files. If present, this should be added to the base url when generating the thumbnail for the example. Adjusted the zoom and center of several examples to start in more interesting locations. Fixed some style issues. If a heatmap was panned before it was ready, it could throw an error. If a reprojection's viewport corners were ill-defined in the projection, the map would fail to draw. For the WMS and SLD examples, switch the URL used for the geoserver to https. This works -- the http server no longer does. For the SLD example, add controls to allow setting the base url, layer name, and projection. Clean up some of the pug code. Update the thumbnail to match what the default settings show.
aashish24
approved these changes
Oct 18, 2017
| @@ -12,40 +12,36 @@ var layer = { | |||
| projection: 'EPSG:3785' | |||
| }; | |||
|
|
|||
| var baseUrl = 'https://demo.boundlessgeo.com/geoserver/ows'; | |||
| if (pt === undefined) { | ||
| var size = map.size(); | ||
| pt = {x: size.width / 2, y: size.height / 2}; | ||
| } | ||
| /* displayToGcs can fail under certain projections. If this happens, |
There was a problem hiding this comment.
how can we replicate this behavior in our current version?
There was a problem hiding this comment.
just curious but agree on the statement
There was a problem hiding this comment.
In the reprojection example, choose a projection that curves at the edges, (ESRI:53009 or any Mollweide will work). Zoom out. If you zoomed out far enough, this code path is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak a few examples to fix some inconsistencies and errors. The goal is for every example to start in an interesting spot, and, moreover, for the thumbnail of the example to be representative of the example.
Added an optional
thumbqueryparameter to example.json files. If present, this should be added to the base url when generating the thumbnail for the example.Adjusted the zoom and center of several examples to start in more interesting locations.
Fixed some style issues.
If a heatmap was panned before it was ready, it could throw an error.
If a reprojection's viewport corners were ill-defined in the projection, the map would fail to draw.
For the WMS and SLD examples, switch the URL used for the geoserver to https. This works -- the http server no longer does (this resolves issue #690).
For the SLD example, add controls to allow setting the base url, layer name, and projection. Clean up some of the pug code. Update the thumbnail to match what the default settings show.