Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting rotation on map creation. #740

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Oct 9, 2017

Add a test that map creation parameters are honored.

Prior to this, you couldn't set the rotation when creating a map. That is,

var map = geo.map({
  node: '#map',
  rotation: Math.PI * 0.5
});

would still have a rotation of 0, despite all other parameters being settable on creation.

Add a test that map creation parameters are honored.
@manthey manthey added the bug label Oct 9, 2017
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@manthey manthey merged commit 3a7f896 into master Oct 13, 2017
@manthey manthey deleted the rotation-on-map-creation branch October 13, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants