Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layers' z-index could be wrong. #732

Merged
merged 1 commit into from
Aug 31, 2017
Merged

New layers' z-index could be wrong. #732

merged 1 commit into from
Aug 31, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Aug 30, 2017

If a layer is deleted and then a new layer is added, the new layer's z-index can be the same as an existing layer.

This changes the default z-index logic to be one greater than any existing layer's z-index. Also, if a layer is set explicitly to the same z-index of another layer, layers are shifted up one z-index value to ensure that all layers have unique z-indices.

If a layer is deleted and then a new layer is added, the new layer's z-index can be the same as an existing layer.

This changes the default z-index logic to be one greater than any existing layer's z-index.  Also, if a layer is set explicitly to the same z-index of another layer, layers are shifted up one z-index value to ensure that all layers have unique z-indices.
Copy link

@matthewma7 matthewma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a try. The issue is fixed with this PR. 👍

@manthey manthey merged commit 4ce1a61 into master Aug 31, 2017
@manthey manthey deleted the fix-layer-z branch August 31, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants