New gh-pages website #729
New gh-pages website #729
Conversation
matthewma7
force-pushed
the
new_website
branch
2 times, most recently
from
46b6819 to
4c211bc
Compare
matthewma7
force-pushed
the
new_website
branch
from
4c211bc to
d687507
Compare
|
@matthewma7 @manthey is this ready for review? |
|
@aashish24 Yes, this is ready for review. |
|
Can we pull the vendor part of the the agency theme from an npm package like |
|
@manthey I think it's not possible to use the npm package anymore. A large amount of code has been removed and refactored. The only thing intact is the name. |
website/_config.yml
Outdated
| ## Source: https://github.com/hexojs/hexo/ | ||
|
|
||
| # Site | ||
| title: Hexo |
There was a problem hiding this comment.
Even if this isn't used anywhere, we should probably update it with better information (or at least remove the placeholder data).
website/scaffolds/draft.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| --- | |||
There was a problem hiding this comment.
If the scaffolds directory isn't used, we should remove it. If it has utility, we should document it.
|
I'd rather not see things like the font-awesome fonts in the repo if we can get them from another location. |
website/_config.yml
Outdated
| filename_case: 0 | ||
| render_drafts: false | ||
| post_asset_folder: false | ||
| relative_link: false |
There was a problem hiding this comment.
Can we set this to true? Doing so will also require changing website/themes/agency/layout/layout.ejs (see comment there). By using relative links, you can use any webserver to test the website, not just use haxo server, and, if we deploy to a sample to a proxied container, the website will still work.
| <li class="hidden"> | ||
| <a href="#page-top"></a> | ||
| </li> | ||
| <% var path = page_url(path); %> |
There was a problem hiding this comment.
If we use relative links, this line needs to be removed, and the following line, instead of testing path === config.root, we can test path === "index.html".
…ite structure; Removes unused files and placeholding fields.
…efore build Hexo will remove spaces and newlines when rendering a json file, we need the spaces and newlines for our example, so ask Hexo to skip rendering json files in example directory.
|
@manthey I addressed improvements you pointed out. but I wasn't able to use the startbootstrap-agency from npm because that version is based on bootstrap 4 but I am using bootstrap 3. This PR is ready for review. |
Reduce code duplication in the example and tutorial build scripts. This moves the enumeration, standardization, and sorting of the tutorial and examples to a single location (examples/build-utils.js).
|
@matthewma7 I pushed a change which automatically generates the example and tutorial lists, plus reduces code duplication in some build files. |
|
Assuming you approve the PR I made, I see one remaining issue I'd like to address on this PR: the "source code" view from the examples has poor styling. Specifically, the These are set by the bootstrap styling, which changes the docco styling. |
|
@manthey Turns out the docco files are preprocessed accidentally. Docco outputs full HTML page already. I think we can leave it as that for now. This is ready for review. |
There was a problem hiding this comment.
Good job, @matthewma7 . If we find anything else, it can be a separate PR.
|
@manthey Cool, Thanks for the reviewing and improvements for this PR. 😉 |
|
great job @matthewma7 and @manthey thanks for getting it in master. |
This PR supersedes #720 and #721. The other two PR are outdated because of project structure change, now we build the whole website locally then copy to gh-pages branch like before.
This PR creates new scripts for building examples and tutorials for the website, and build the website itself.