Better checks for external modules. #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3 and HammerJS are intended to be optional modules. Consumers of geojs (at least those that don't use webpack) improperly report that these modules are always available.
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 95.26% 95.26% +<.01%
==========================================
Files 84 84
Lines 8990 8994 +4
==========================================
+ Hits 8564 8568 +4
Misses 426 426
Continue to review full report at Codecov.
|
|
We might also want to change the public symbol for hammerjs in the webpack config (https://github.com/OpenGeoscience/geojs/blob/master/webpack.config.js#L46). If you include hammerjs as a global, it is exported to |
|
@jbeezley Is the change I made sufficient? Is there some sensible way to add a test for gracefully not using Hammer if it isn't available? |
|
The change looks good. I don't know of any good ways of testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D3 and HammerJS are intended to be optional modules. Consumers of geojs (at least those that don't use webpack) improperly report that these modules are always available.