Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mock VGL functions to util #688

Merged
merged 3 commits into from
Apr 27, 2017
Merged

Move mock VGL functions to util #688

merged 3 commits into from
Apr 27, 2017

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Apr 26, 2017

This will make in convenient for other projects to test geojs in non-webgl browsers.

Also, this now allow multiple contexts to be mocked.

manthey added 2 commits April 26, 2017 08:49
This will make in convenient for other projects to test geojs in non-webgl browsers.
@manthey
Copy link
Contributor Author

manthey commented Apr 26, 2017

I expect the travis tests to fail since Firefox 53 has been released. It has changed something in the button padding that is messing things up.

@jbeezley
Copy link
Contributor

I'm okay with the changes. Do you need to update the screenshots for Firefox 53?

@codecov-io
Copy link

codecov-io commented Apr 26, 2017

Codecov Report

Merging #688 into master will decrease coverage by <.01%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   95.24%   95.23%   -0.01%     
==========================================
  Files          83       84       +1     
  Lines        8850     8919      +69     
==========================================
+ Hits         8429     8494      +65     
- Misses        421      425       +4
Impacted Files Coverage Δ
src/util/index.js 100% <100%> (ø) ⬆️
src/util/mockVGL.js 91.17% <91.17%> (ø)
src/polyfills.js 25% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c4eaf...3f52df8. Read the comment docs.

@manthey manthey merged commit 1103e98 into master Apr 27, 2017
@manthey manthey deleted the mock-vgl-as-util branch April 27, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants