Allow slider widget to be repositioned #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nicer if you could change the orientation and which ends had the + and - (or even if they appeared). You can invoke the slide with the position option, which can contain offsets from the top, left, right, or bottom (or some combination thereof). It can also take a width and height, which are honored, though height needs to be more than 3.5 times the width or stupid things will happen.
|
@dorukozturk Give this a try, passing something like |
Current coverage is 85.39% (diff: 80.00%)@@ master #619 diff @@
==========================================
Files 85 85
Lines 8211 8217 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7012 7017 +5
- Misses 1199 1200 +1
Partials 0 0
|
manthey
changed the title
|
Looks reasonable to me but I will let @dorukozturk or @jbeezley approve it. |
I noticed two defects in positioning widgets. If you position a widget, a css property gets set and had no way to get unset. Therefore, if you set the position via x, y or top, left, then tried to set it by bottom, right, the top, left css would still be present and prevent the desired position. Further, 'px' was always added to the style, preventing clearing parameters via 'auto' or null (or using expressions like '20%').
|
@jbeezley I added another change. If you'd prefer, I could back it out and add it as a separate PR. I also notice we don't test setting a widget position after its creation. I'll add a test for that and for the recent change. |
|
That's fine with me. Thanks. |
|
@jbeezley If this most recent change LGTY let me know (or just merge). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nicer if you could change the orientation and which ends had the + and - (or even if they appeared).
You can invoke the slide with the position option, which can contain offsets from the top, left, right, or bottom (or some combination thereof). It can also take a width and height, which are honored, though height needs to be more than 3.5 times the width or stupid things will happen.
This addresses issue #618.