Annotation geojson #617
Merged
Annotation geojson #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order is not guaranteed to be the same as the exported order; points will end up before rectangles and polygons due to grouping by the geojson reader.
manthey
force-pushed
the
annotation-geojson
branch
from
2e113e5 to
476f0fd
Compare
You can edit the geojson live.
manthey
force-pushed
the
annotation-geojson
branch
from
476f0fd to
b876b37
Compare
Current coverage is 85.39% (diff: 100%)@@ master #617 diff @@
==========================================
Files 85 85
Lines 8019 8211 +192
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6641 7012 +371
+ Misses 1378 1199 -179
Partials 0 0
|
|
@aashish24 This is ready for review. |
|
Cool! Will review it soon, thanks 👏 👏 |
aashish24
reviewed
Sep 30, 2016
| @@ -8,7 +8,7 @@ var exampleUtils = { | |||
| '&').map(function (n) { | |||
| n = n.split('='); | |||
| if (n[0]) { | |||
| this[decodeURIComponent(n[0])] = decodeURIComponent(n[1]); | |||
| this[decodeURIComponent(n[0].replace(/\+/g, '%20'))] = decodeURIComponent(n[1].replace(/\+/g, '%20')); | |||
There was a problem hiding this comment.
decodeURIComponent doesn't decode + to a space in Chrome, but urls are allowed to use + to encode spaces.
| * annotations and leave unchanged annotations. | ||
| * @param {string|geo.transform} [gcs] undefined to use the interface gcs, | ||
| * null to use the map gcs, or any other transform. | ||
| * @param {boolean} includeCrs: if true, include the coordinate system in the |
There was a problem hiding this comment.
should we rename includeCrs to includeGcs to be consistent?
There was a problem hiding this comment.
In geojson it is called crs. Since this affects the geojson output, I figured it should be crs in this context, not gcs.
There was a problem hiding this comment.
okay thats fine, I just thought that everywhere else we used gcs but I don't have strong feeling about it.
aashish24
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation layers can output and input geojson. Using its own geojson will reconstruct the annotations (though they may have different internal IDs). Modifying the geojson updates the annotations.
The annotation example has the ability to live-edit the geojson.
This requires PR #616.