-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance canvas heatmap #574
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e9592b2
Using typed array to increase performance
aashish24 19557f8
Using event data for transformation
aashish24 fadaa91
Fix intermediate transforms and update delays on the heatmap.
manthey 037c106
A minor speed-up can be obtained by directly setting transforms rathe…
manthey d0cb87c
Rename origin to gcsOrigin to make it more obvious it isn't in displa…
manthey 5e23638
Reduce number of function calls for a minor speed improvement.
manthey 47e461a
Precompute gcs positions for heatmaps.
manthey f2c6a68
Loops can be faster than functions.
manthey f52faa5
Fix some issues setting max and min intensity.
manthey b4801bd
Fixed Endian check
aashish24 8f25c0a
Do not use typed array on big-endian systems
aashish24 ec76824
Simplify _colorize.
manthey a1db91b
Remove opacity as a heatmap feature property.
manthey 3b8fa85
Switch to a single var statement.
manthey ee6500e
Complete coverage of src/heatmapFeature.js.
manthey 62b0e77
Add tests for _animatePan.
manthey 10da56c
Merge branch 'master' into improve_performance_canvas_heatmap
aashish24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try this out in the Chrome console, it doesn't work.
m_typedBuffer
references anArrayBuffer
, which doesn't give me index reference access to the array. I think this comparison needs to be on them_typedClampedBuffer
, not onm_typedBuffer
. What is here works, but only because we've only tried in on little-endian machines.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. let me have a look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manthey yes, it should be on clamped buffer, thanks for report this. I pushed a fix.