Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some needless calls. #1039

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Remove some needless calls. #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## Unreleased

### Bug Fixes
- Removed extra calls to sceneObject constructors (#1039)

## Version 0.19.7

### Features
Expand Down
5 changes: 0 additions & 5 deletions src/canvas/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
var inherit = require('../inherit');
var sceneObject = require('../sceneObject');

/**
* Canvas specific subclass of object which rerenders when the object is drawn.
* @class
Expand All @@ -19,7 +16,6 @@ var canvas_object = function (arg) {
if (!(this instanceof object)) {
return new canvas_object(arg);
}
sceneObject.call(this);

var m_this = this,
s_draw = this.draw,
Expand Down Expand Up @@ -81,5 +77,4 @@ var canvas_object = function (arg) {
return this;
};

inherit(canvas_object, sceneObject);
module.exports = canvas_object;
5 changes: 0 additions & 5 deletions src/svg/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
var inherit = require('../inherit');
var sceneObject = require('../sceneObject');

/**
* SVG specific subclass of object which adds an id property for d3 selections
* on groups of objects by class id.
Expand All @@ -22,7 +19,6 @@ var svg_object = function (arg) {
if (!(this instanceof object)) {
return new svg_object(arg);
}
sceneObject.call(this);

var m_id = 'svg-' + uniqueID(),
s_exit = this._exit,
Expand Down Expand Up @@ -66,5 +62,4 @@ var svg_object = function (arg) {
return this;
};

inherit(svg_object, sceneObject);
module.exports = svg_object;